Re: [PATCH 0/2] ACPI: return error in acpi_pci_irq_enable when there is no irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[+cc Yinghai]

On Fri, Sep 13, 2013 at 5:43 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Friday, September 13, 2013 08:52:18 AM Prarit Bhargava wrote:
>>
>> On 08/08/2013 08:35 AM, Heikki Krogerus wrote:
>> > Hi,
>> >
>> > This is the fix for the Dell PowerEdge 840 issue where nothing
>> > allocated an irq for it's PCH if I understood correctly. The issue was
>> > reported by Prarit Bhargava.
>> >
>> > The second patch is just a minor cleanup.
>> >
>> > Thanks,
>> >
>> >
>> > Heikki Krogerus (2):
>> >   ACPI / PCI: don't allow PCI devices without irq to be enabled
>> >   ACPI / PCI: remove an extra check from acpi_pci_irq_enable()
>> >
>>
>> Rafael, is this in your queue?
>
> No, it is not, because Bjorn wanted to debug this issue deeper as far as I
> could understand.
>
> Bjorn?

Yes.  Yinghai pointed out a possible issue ("some USB3 host controller
does not have intx configured, but still work with MSI?").  I can't
explain to you right now what that means, but I did look at it enough
to think that there indeed might be a problem there.

So I asked [1] for a bugzilla with more info (dmesg, acpidump) so
somebody could look at it.  Actually, I was hoping Heikki or Prarit
would look into it and address Yinghai's concern.  Maybe there's no
problem there, but we should at least look and explain *why* it's not
a problem.  And I would really like a kernel.org bugzilla with the
info, in case this change turns out to have unintended consequences
and we have to debug it again later.

Bjorn

[1] http://lkml.kernel.org/r/CAErSpo7KDY87QPLNwbufeUAFGBtvyGteDmk6AxqFXBOX0RaObw@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux