Hello, Alexander.
On Thu, Sep 05, 2013 at 02:52:47PM +0200, Alexander Gordeev wrote:
> -int pci_enable_msi_block_part(struct pci_dev *dev,
> - unsigned int nvec, int nvec_mme)
> +int pci_get_msi_cap(struct pci_dev *dev)
> {
> - int status, maxvec;
> + int ret;
> u16 msgctl;
>
> if (!dev->msi_cap)
> return -EINVAL;
>
> pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &msgctl);
> - maxvec = 1 << ((msgctl & PCI_MSI_FLAGS_QMASK) >> 1);
> + ret = 1 << ((msgctl & PCI_MSI_FLAGS_QMASK) >> 1);
> +
> + return ret;
> +}
> +EXPORT_SYMBOL(pci_get_msi_cap);
One curiosity - with the above factored out, is
pci_enable_msi_block_part() returning positive number still necessary?
I followed most of code paths in x86 and nothing seems to need it and
positive return seems to be just causing confusion - ie. returning 1
on multiple msi config failure from some functions, which is silly.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
