On Mon, Aug 26, 2013 at 11:36:21AM -0400, Neil Horman wrote: > From: root <root@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > Somewhere between 3.9 and 3.10 it seems the order in which pcie and acpi probed > slots for hotplug capabilites got reversed. While this isn't a big deal, it did > uncover a bug in the ACPI bus setup path. Specifically, acpi_pci_root_add calls > pci_acpi_scan_root before setting the osc flags for the device handle. > pci_acpi_scan_root, among other things uses device_is_managed_by_native_pciehp() > to determine if a given slot has pcie hotplug capabilties, whcih checks the > devices OSC_PCI_EXPRESS_NATIVE_HP_CONTROL flag. Since that flag is not set > until after pci_acpi_scan_root_completes, the acpi code never sees that pcie > slots are hotplug capable and configures them all to use acpi instead. > > Fix is pretty simple, just defer the scan until after the osc flags have been > set on the device. Tested by myself and it seems to work well. > > Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx> > CC: Len Brown <lenb@xxxxxxxxxx> > CC: "Rafael J. Wysocki" <rjw@xxxxxxx> > CC: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > CC: linux-acpi@xxxxxxxxxxxxxxx > CC: linux-pci@xxxxxxxxxxxxxxx > Sorry, self NAK on this, sorry, I forgot to fix up authorship from my development machine. I'll resend in a second. Neil -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
