Re: [PATCH v2 2/3] PCI: Separate stop and remove devices in pciehp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> in your test: the PF is not get freed but it is removed for bus's device list.
>> so pciehp_configure_device will create new one even the old is not
>> really released.
>
> Yes.  As I said above, I do see the leak of the PF pci_dev, and
> we certainly do need to fix that, but it's not a regression and
> doesn't seem urgent.
>
>> Please check with attached patch, that only release that from link-list in
>> pci_release device. I posted it a while back.
>> After it get applied, you will not have chance to create new device in
>> pciehp_configure_device.
>
> [I inlined your patch for convenience]
>
> I agree that the patch below looks like a good thing to do.
> However, it is not in v3.11.  So if the problem only happens when
> the patch below is applied, we don't need to fix the problem in
> v3.11.

ok.

>
> I've spent a LOT of time trying to reproduce this problem and
> convince myself that we need to do something in v3.11.  If you're
> telling me that my time was wasted because the problem does not
> happen in v3.11-rc, but only happens with your out-of-tree patch,
> I'm going to be very upset.

sorry, I did not notice that. I should test without that patch.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux