On Wed, Aug 14, 2013 at 11:25:02AM +0200, Sebastian Hesselbarth wrote: > On 08/14/2013 11:07 AM, Thierry Reding wrote: > >On Tue, Aug 13, 2013 at 02:25:23PM +0200, Sebastian Hesselbarth wrote: > >[...] > >>diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c > >[...] > >>@@ -897,6 +904,30 @@ static int mvebu_pcie_probe(struct platform_device *pdev) > >[...] > >>+ u32 reset_udelay = 20000; > >[...] > >>+ udelay(reset_udelay); > > > >udelay(20000) is probably not a good idea. You should probably use > >something like usleep_range() or msleep() here. Also see: > > > > Documentation/timers/timers-howto.txt > > Thierry, > > thanks for mentioning this. I clearly got distracted from ms to us > switch due to the different reset API convention. As the delay will > be most likely 10ms+, we should change the above to > msleep(reset_udelay/1000) instead. I'll just go ahead and fix this up locally. No need to resend. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
