On Mon, Aug 5, 2013 at 1:59 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >> then, we should drop that 4k capping. >> I was thinking there could be strange or wild res with bigger than 4k. > > If there *were* an I/O BAR larger than 4KB, how should it be handled? > I don't think capping the alignment to 4KB sounds like the best way. > For example, a 16KB I/O BAR would still need to be aligned on 16KB. > > And I think capping to 4KB as you did above will break the powerpc > pcibios_window_alignment() implementation. For example, if > pcibios_window_alignment() returned 16KB, and we later capped it to > 4KB, we're going to allocate space for the bridge window with the > wrong alignment. Agree. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
