Re: [PATCH -v4 1/6] PCI,pciehp: avoid add a device already exist before suspend during resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yijing,

On Thu, 2013-08-01 at 21:06 +0800, Yijing Wang wrote:
> Currently, pciehp_resume() try to hot add device if the slot adapter
> status return true. But if there are already some devices exist,
> namely list_empty(bus->devices) return false. We should not add the device
> again, because the device add action will fail. Also print some uncomfortable
> messages like this:
> 	pciehp 0000:00:1c.1:pcie04: Device 0000:03:00.0 already exists at 0000:03:00, cannot hot-add
> 	pciehp 0000:00:1c.1:pcie04: Cannot add device at 0000:03:00
> 
> Tested-by: Paul Bolle <pebolle@xxxxxxxxxx>
> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx>
> Cc: Paul Bolle <pebolle@xxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>
> Cc: Oliver Neukum <oneukum@xxxxxxx>
> Cc: Gu Zheng <guz.fnst@xxxxxxxxxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx

0) There's no 0/6 in my mailbox, so I reply to this message.

1) This series applies cleanly on top of v3.10.5-rc1 (except for some
odd problem in 6/6, which I mentioned in my reply to 6/6).

2) However, this series doesn't appear to work on v3.10.5-rc1. After the
first resume the wireless connection appears to be gone (in Gnome 3).
iwl4965 is still loaded, but I can't reconnect. That should happen
automagically.

3) And the second resume apparently hangs the system. Not sure how it
hangs exactly, but I have to manually shutdown the laptop by pressing
the power button for a few seconds.

4) I guess I'll have to respin v3.10.5-rc1 without this series to
determine if v3.10.5-rc1 or this series causes these issues. But feel
free to prod me for further tests.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux