On Tuesday, July 30, 2013 09:40:18 AM Bjorn Helgaas wrote: > On Tue, Jul 30, 2013 at 7:59 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > > On Tuesday, July 30, 2013 10:32:30 AM tianyu.lan@xxxxxxxxx wrote: > >> From: Lan Tianyu <tianyu.lan@xxxxxxxxx> > >> > >> acpi_pci_set_power_state() produces log of device power state changing. > >> Now the log is produced by dev_info(). This seems make no sense when user > >> doesn't open debug option. So change it to dev_dbg() and prevent kernel > >> log from being. > >> > >> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=60636 > >> Suggested-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > >> Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx> > > > > Bjorn, what do you think about this? > > It's fine with me. For information that I want in the dmesg log all > the time, with no special action from the user, I personally avoid > dev_dbg() because I can never figure out whether it's enabled or not. > But I don't use the information from this printk, so it's completely > up to you. Just let me know what you want. If you have other pending > changes to this file, you can take it, or I can put it in my tree. Yes, I have one change to this file in my queue for 3.12, so I can take this patch. Thanks, Rafael > >> --- > >> drivers/pci/pci-acpi.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c > >> index c78cc43..fb3522957 100644 > >> --- a/drivers/pci/pci-acpi.c > >> +++ b/drivers/pci/pci-acpi.c > >> @@ -210,7 +210,7 @@ static int acpi_pci_set_power_state(struct pci_dev *dev, pci_power_t state) > >> } > >> > >> if (!error) > >> - dev_info(&dev->dev, "power state changed by ACPI to %s\n", > >> + dev_dbg(&dev->dev, "power state changed by ACPI to %s\n", > >> acpi_power_state_string(state_conv[state])); > >> > >> return error; > >> > > -- > > I speak only for myself. > > Rafael J. Wysocki, Intel Open Source Technology Center. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
