On Fri, Jul 26, 2013 at 2:10 AM, ethan zhao <ethan.zhao@xxxxxxxxxx> wrote:
> Cleanup the -EINVAL return value handling and add warning message for
> invalid
> start,end,addr parameters.
>
> Signed-off-by: ethan.zhao <ethan.zhao@xxxxxxxxxx>
> ---
> arch/x86/pci/mmconfig-shared.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
> index 082e881..37f6c7f 100644
> --- a/arch/x86/pci/mmconfig-shared.c
> +++ b/arch/x86/pci/mmconfig-shared.c
> @@ -700,8 +700,13 @@ int pci_mmconfig_insert(struct device *dev, u16 seg, u8
> start, u8 end,
> if (!(pci_probe & PCI_PROBE_MMCONF) || pci_mmcfg_arch_init_failed)
> return -ENODEV;
>
> - if (start > end)
> + if (start > end || !addr) {
> + dev_warn(dev, FW_WARN
> + "Invalid address to add MMCONFIG"
> + "start %02x end %02x addr %pR\n",
> + start, end, addr);
> return -EINVAL;
> + }
>
> mutex_lock(&pci_mmcfg_lock);
> cfg = pci_mmconfig_lookup(seg, start);
> @@ -716,11 +721,6 @@ int pci_mmconfig_insert(struct device *dev, u16 seg, u8
> start, u8 end,
> return -EEXIST;
> }
>
> - if (!addr) {
> - mutex_unlock(&pci_mmcfg_lock);
> - return -EINVAL;
> - }
> -
> rc = -EBUSY;
> cfg = pci_mmconfig_alloc(seg, start, end, addr);
> if (cfg == NULL) {
Acked-by: Yinghai Lu <yinghai@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
