On Fri, Jul 19, 2013 at 2:46 PM, Alexander Duyck
<alexander.h.duyck@xxxxxxxxx> wrote:
> On 07/19/2013 12:14 PM, Yinghai Lu wrote:
>> After commit dc087f2f6a2925e81831f3016b9cbb6e470e7423
>> (PCI: Simplify IOV implementation and fix reference count races)
>> VF need to be removed via virtfn_remove to make sure ref to PF
>> is put back.
>>
>> Some driver (like ixgbe) does not call pci_disable_sriov() if
>> sriov is enabled via /sys/.../sriov_numvfs setting.
>> ixgbe does allow driver for PF get detached, but still have VFs
>> around.
>>
>> But how about PF get removed via /sys or pciehp?
>>
>> During hot-remove, VF will still hold one ref to PF and it
>> prevent PF to be removed.
>> That make the next hot-add fails, as old PF dev struct is still around.
>>
>> We need to add pci_disable_sriov() calling during pci dev removing.
>>
>> Need this one for v3.11
>>
>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>> Cc: Jiang Liu <liuj97@xxxxxxxxx>
>> Cc: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>
>> Cc: Donald Dutile <ddutile@xxxxxxxxxx>
>> Cc: Greg Rose <gregory.v.rose@xxxxxxxxx>
>>
>> ---
>> drivers/pci/remove.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> Index: linux-2.6/drivers/pci/remove.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/pci/remove.c
>> +++ linux-2.6/drivers/pci/remove.c
>> @@ -34,6 +34,9 @@ static void pci_stop_dev(struct pci_dev
>>
>> static void pci_destroy_dev(struct pci_dev *dev)
>> {
>> + /* remove VF, if PF driver skip that */
>> + pci_disable_sriov(dev);
>> +
>> down_write(&pci_bus_sem);
>> list_del(&dev->bus_list);
>> up_write(&pci_bus_sem);
>>
>
> How are you able to hot-remove the PF if the VFs are still holding
> references to it?
usually pci_stop_and_remove_bus_device always successfully, and
power get turned off for that card.
>
> The issue I see with this patch is that if the PF has any VFs direct
> assigned, hot plug removing the PF will cause the guests containing
> those VFs to panic.
Then you should make guest support hotplug or suprise removal.
If the guest does panic because it does support hotplug, that is right behavior.
Just like in bare metal machine, if it does not support hotplug, and user would
know what is going to happen if he remove one pcie card.
Thanks
Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
