Rob, On Tue, 9 Jul 2013 08:43:36 -0500, Rob Herring wrote: > > +int of_msi_chip_add(struct msi_chip *chip) > > Perhaps of_pci_msi_chip_add instead. Sure, makes sense. > > +{ > > + struct msi_chip *c; > > + list_for_each_entry(c, &msi_chip_list, list) { > > Need the safe variant here? As suggested by Bjorn, I've changed this function to grab the msi_chip_mutex while traversing the list. Does your e-mail implies that the general approach seems ok? If so, I'll resend an updated v5 version taking into account the comments that I have received on this v4. Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html