Dear Bjorn Helgaas,
On Fri, 5 Jul 2013 15:56:55 -0600, Bjorn Helgaas wrote:
> > +int of_msi_chip_add(struct msi_chip *chip)
> > +{
> > + if (! of_property_read_bool(chip->of_node, "msi-controller"))
>
> The space between "! of_property..." is atypical.
Indeed.
> > +struct msi_chip *of_find_msi_chip_by_node(struct device_node *of_node)
> > +{
> > + struct msi_chip *c;
>
> Normally there's a blank line here.
>
> The list traversal below isn't safe, is it? A simultaneous remove,
> e.g., of an MSI chip unrelated to the one we're looking up, might
> change the list while we're traversing it.
True, will fix!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
