On Tue, Jun 25, 2013 at 3:55 AM, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> wrote: > Dear Bjorn Helgaas, > > On Mon, 24 Jun 2013 19:52:45 -0600, Bjorn Helgaas wrote: > >> I agree; the whole point of __weak is to provide a "default" >> implementation, so I hope you can just remove any empty default_*() >> functions and fold the others into the arch_*() functions directly. >> >> If there actually are callbacks from arch-specific strong functions >> back to the stuff in the default_*() functions, that suggests that we >> should refactor and rename that bit of functionality. > > There is one such case, as highlighted in the commit log of this patch: > > """ > This is needed because the x86 Xen implementation of > teardown_msi_irqs() needs to do some work, and then call the default > implementation of this hook. > """ > > Any suggestion on how to solve this particular case? Nope. Just leave it as-is for that case and consolidate what you can. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
