On Fri, Jun 21, 2013 at 01:14:23AM +0800, Jiang Liu wrote: > On 06/21/2013 01:08 AM, Greg Kroah-Hartman wrote: > > On Fri, Jun 21, 2013 at 01:01:05AM +0800, Jiang Liu wrote: > >> From: Jiang Liu <jiang.liu@xxxxxxxxxx> > >> > >> Mark pci_scan_bus_parented() as __deprecated and clean up outdated > >> comments. > > > > Why not just delete the function, if no in-kernel users are calling it, > > it's no longer needed at all. > Hi Greg, > I thought that may break out of tree drivers, so give a warning first > for smooth transitions. Any guidelines here? I have some other similar > cases to keep some exported symbols just for out of tree drivers. Don't care about out-of-tree drivers, as they obviously don't care about you, or the in-kernel code. You are doing no one any favors by keeping these functions around for a while, only delaying the time that these out-of-tree drivers will have to be updated, they will not be updated by a mere __depreciated warning. So just delete them, that's what the rest of the kernel does, it's the price that out-of-tree drivers pay, and the authors of them know this quite well. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
