Dear Thierry Reding, On Wed, 12 Jun 2013 12:42:40 +0200, Thierry Reding wrote: > On Thu, Jun 06, 2013 at 06:41:24PM +0200, Thomas Petazzoni wrote: > [...] > > @@ -292,6 +454,8 @@ static int __init armada_370_xp_mpic_of_init(struct device_node *node, > > > > #endif > > > > + armada_370_xp_msi_init(node); > > + > > So I see that you don't have access to the original platform device > here, but you could use of_find_device_by_node() to obtain it and pass > that into armada_370_xp_msi_init() in order to set the msi_chip.dev > field. Or you could do the lookup in armada_370_xp_msi_init() if you > don't need it for anything else in armada_370_xp_mpic_of_init(). As I replied to Grant, of_find_device_by_node() returns NULL, I believe because the all IRQ controller driver initialization is done pretty early, before the of_platform_populate() call is made, so there is no platform_device associated with the IRQ controller node at the time the armada_370_xp_mpic_of_init() function is called. Do you see another approach, especially in relation to your comment on PATCH 2/8 ? Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
