On Fri, Jun 14, 2013 at 3:27 PM, Matthew Garrett <matthew.garrett@xxxxxxxxxx> wrote: > On Fri, 2013-06-14 at 15:17 -0700, Yinghai Lu wrote: > >> after those two patches, it aspm_disabled is set, via _osc early, >> pre-1.1 devices aspm register will be touched even aspm_force is not specified. > > I don't follow. We were previously automatically disabling ASPM on > pre-1.1 devices even if _OSC didn't give us control. I don't think so, we just moved _OSC support/control setting before pci scan in 3.8 and revert that in v3.9. > I've confirmed that > this was the wrong thing for us to be doing, and my patch changed the > behaviour such that if the firmware enables ASPM on a pre-1.1 device and > refuses to give us control via _OSC we will leave ASPM enabled. not sure, aspm_disabled should be false on booting path when that function is called, if you don't pass aspm=off. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
