On Thu, 2013-06-06 at 12:10 -0600, Betty Dall wrote: > The function aer_recover_queue() is a public interface and the > severity argument uses #defines that are in the private header > pci/pcie/aer/aerdrv.h. > > This patch moves the #defines from pci/pcie/aer/aerdrv.h to > include/linux/aer.h. [] > diff --git a/include/linux/aer.h b/include/linux/aer.h [] > -extern void cper_print_aer(const char *prefix, struct pci_dev *dev, > +void cper_print_aer(const char *prefix, struct pci_dev *dev, > int cper_severity, struct aer_capability_regs *aer); Can you please also realign the arguments on subsequent lines to the open parenthesis of the first line and reflow then to 80 cols when appropriate? > -extern void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, > +void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, > int severity); -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html