[+cc Konrad, Jeremy, xen-devel (users of interface you're deprecating)] On Sat, May 25, 2013 at 7:48 AM, Jiang Liu <liuj97@xxxxxxxxx> wrote: > Mark pci_scan_bus_parented() as __deprecated and clean up outdated > comments. > > Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx> > Cc: Chris Metcalf <cmetcalf@xxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx > --- > arch/tile/kernel/pci.c | 3 --- > include/linux/pci.h | 4 ++-- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/tile/kernel/pci.c b/arch/tile/kernel/pci.c > index 67237d3..936e087 100644 > --- a/arch/tile/kernel/pci.c > +++ b/arch/tile/kernel/pci.c > @@ -309,9 +309,6 @@ int __init pcibios_init(void) > * > * It reads the PCI tree for this bus into the Linux > * data structures. > - * > - * This is inlined in linux/pci.h and calls into > - * pci_scan_bus_parented() in probe.c. > */ > pci_add_resource(&resources, &ioport_resource); > pci_add_resource(&resources, &iomem_resource); > diff --git a/include/linux/pci.h b/include/linux/pci.h > index b0f4a82..7b23fa0 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -720,8 +720,8 @@ void pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res, > void pcibios_scan_specific_bus(int busn); > struct pci_bus *pci_find_bus(int domain, int busnr); > void pci_bus_add_devices(const struct pci_bus *bus); > -struct pci_bus *pci_scan_bus_parented(struct device *parent, int bus, > - struct pci_ops *ops, void *sysdata); > +struct pci_bus * __deprecated pci_scan_bus_parented(struct device *parent, > + int bus, struct pci_ops *ops, void *sysdata); > struct pci_bus *pci_scan_bus(int bus, struct pci_ops *ops, void *sysdata); > struct pci_bus *pci_create_root_bus(struct device *parent, int bus, > struct pci_ops *ops, void *sysdata, I think this patch is a good idea, but I think we need to change the only existing user of pci_scan_bus_parented() (pcifront_scan_root() in drivers/pci/xen-pcifront.c) at the same time, so xen doesn't start getting build warnings. The deprecation warnings are really intended for out-of-tree users that we aren't able to fix ourselves. I'm getting this series queued up in http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/jiang-bus-lock-v3, so if you want to send a patch just for xen, I can fold that in. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
