On Mon, Apr 08, 2013 at 04:29:07PM -0600, Bjorn Helgaas wrote:
> On Tue, Mar 26, 2013 at 10:52 AM, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> wrote:
[...]
> > +static int mvebu_pcie_setup_msi_irq(struct msi_chip *chip,
> > + struct pci_dev *pdev,
> > + struct msi_desc *desc)
> > +{
> > + struct mvebu_pcie_msi *msi = to_mvebu_msi(chip);
>
> If this took only the pci_dev (not the msi_chip), I think you could do this:
>
> struct mvebu_pcie_msi *msi = &pdev->bus->sysdata->msi;
That would mean that the arch_setup_msi_irq() and friends could still be
architecture-agnostic because they only pass around pci_dev, and the
driver specific implementations would know how to lookup sysdata and
from there the MSI chip.
So I was almost convinced that putting the struct msi_chip pointer into
sysdata is a good idea. However that also means that each PCI host
bridge driver becomes architecture-specific. If we ever get a driver
that can be used on multiple architectures (however unlikely), the only
way to make it work would be to #ifdef those parts. We could make that
easier to deal with by providing an accessor (pci_sysdata_set_msi_chip()
or similar), though.
But maybe it's something we don't need to be concerned about because no
PCI host bridge driver will ever support two different architecture?
One related point is compile coverage. If the drivers are completely
architecture-agnostic it makes it a lot easier to compile-test all
drivers, which might come in useful when doing core changes and such.
Thierry
Attachment:
pgpwCniSt9bJZ.pgp
Description: PGP signature
