On Tue, May 28, 2013 at 10:31:51AM -0600, Bjorn Helgaas wrote: > On Tue, May 28, 2013 at 5:36 AM, Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote: > > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: > >> pcibios_add_device() is mostly called at boot-time, when > >> early_ioremap() probably works well. But it's also called when we > >> hot-add devices later, and it looks like early_ioremap() will then > >> generate warnings because "system_state != SYSTEM_BOOTING". > > > > Oops. Good point. Is there any reason we can't use ioremap()? > > I assume Matthew had some reason for avoiding that in the first place, > so I hope he'll chime in. I have no recollection of why I did it that way. If this is all happening late enough for ioremap() to work then that sounds fine. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html