On Mon, Apr 15, 2013 at 06:41:17PM -0400, Neil Horman wrote: > +#ifdef CONFIG_IRQ_REMAP > +static void __init intel_remapping_check(int num, int slot, int func) > +{ > + u8 revision; > + > + revision = read_pci_config_byte(num, slot, func, PCI_REVISION_ID); > + > + /* > + * Revision 0x13 of this chipset supports irq remapping > + * but has an erratum that breaks its behavior, flag it as such > + */ > + if (revision == 0x13) > + irq_remap_broken = 1; > + > +} > +#else Any reason why you don't check this in the Intel IOMMU init code? You would safe the ifdefs and you don't have to include irq-remapping-internal header files somewhere else in the tree. Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html