> On Mon, Apr 15, 2013 at 6:49 PM, Yijing Wang <wangyijing@xxxxxxxxxx> wrote: >> Hi Yinghai, >> Any comments about this patch? I searched the code history and found >> you introduced pci_hp_add_bridge() function at commit a8e4b9c10. In your >> patchset use pci_hp_add_bridge() for all pci hotplug drivers except acpiphp. >> So I use pci_hp_add_bridge() in acpiphp instead of using pci_scan_bridge() >> directly. I would appreciate if you can give some suggestions. Hi Yinghai, Thanks for your review and comments very much! > > There is one problem in your patch. > max start value get change. before your patch max is the maximum value > of bus all children... > now it is change bus start value. Thank you for reminding. Now I noticed this detail.(: I will drop these pathes. Thanks! Yijing. > > looks like old code try to handle the case that we already some > children on that bus. > > Last time i did not change it, because i think it only is ready after > busn_res alloc patchset > is merged. > > in pci-mini summit of last year, Bjorn asked Linus about that > patchset, and Linus said it is > risky and it is not worthy to merge it . > > so assume we should hold your patch as it could cause some regression. > > Thanks > > Yinghai > > . > -- Thanks! Yijing -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
