On Monday 08 April 2013, Thomas Petazzoni wrote: > > > + pcie->io.name = "I/O"; > > > + pcie->realio.start = PCIBIOS_MIN_IO; > > > + pcie->realio.end = > > > min(resource_size(&pcie->io), > > > + IO_SPACE_LIMIT); > > > > Using "resource_size(&pcie->io)" here seems strange -- are you > > assuming that pcie->io starts at address zero? > > No, I'm assuming PCIBIOS_MIN_IO is always 0. So presumarly, this should > be something like: > > pcie->realio.end = min(PCIBIOS_MIN_IO + > resource_size(&pcie->io), > IO_SPACE_LIMIT); > Normally PCIBIOS_MIN_IO is 0x1000, since the first 4096 ports are reserved for ISA and PCMCIA compatible drivers and should not be assigned to PCI devices. So the first port should get ports 0x1000 to 0xffff, later ones can used the entire 65536 ports e.g. 0x10000 to 0x1ffff. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
