Re: 3.9-rc1: pciehp and eSATA card SiI 3132, no XHCI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday, March 31, 2013 12:12:47 AM Martin Mokrejs wrote:
> Rafael J. Wysocki wrote:
> > On Saturday, March 30, 2013 06:49:36 PM Martin Mokrejs wrote:
> >> Martin Mokrejs wrote:
> >>> Rafael J. Wysocki wrote:
> >>>> On Saturday, March 30, 2013 02:17:38 AM Martin Mokrejs wrote:
> >>>>> Rafael J. Wysocki wrote:
> >>>>>> On Friday, March 29, 2013 03:11:13 PM Martin Mokrejs wrote:
> >>>>>>> Hi Ying,
> >>>>>>>   thank you for the patch. Here are the results.
> >>>>>>>
> >>>>>>> Huang Ying wrote:
> >>>>>>>> On Thu, 2013-03-28 at 19:38 +0100, Martin Mokrejs wrote:
> >>>>>>>>> Hi Ying,
> >>>>>>>>>   would you please tell me how this report relate to this patch?
> >>>>>>>>>
> >>>>>>>>> [PATCH] PCI / ACPI: Always resume devices on ACPI wakeup notifications
> >>>>>>>>>
> >>>>>>>>>   Could you tell me why this PME was being flipped back and forth now?
> >>>>>>>>> Actually, does that make finally some sense to you, pci/acpi devs?
> >>>>>>
> >>>>>> Can you please test this patch:
> >>>>>>
> >>>>>> https://patchwork.kernel.org/patch/2359611/
> >>>>>>
> >>>>>> and report back as I asked you?
> >>>>>
> >>>>> Sorry for the delay I just had to sort out what belongs under what thread
> >>>>> and the patch was under the other. But I agree its testing with this
> >>>>> particular eSATA/ExpressCardSlot/PM fits better here.
> >>>>>
> >>>>>
> >>>>> The good news is that the eSATA card hotplug works almost perfectly with the patch.
> >>>>> I cold booted as always with the card in the slot already loaded, same kernel
> >>>>> .config and commandline options as described under this thread. But the kernel
> >>>>> was 3.8.3! Not 3.9-rc1.
> >>>>
> >>>> Good.  The goal was to fix the problem with eSATA hotplug.
> >>>
> >>> I thought that was aimed at the XHCI dead port issue. ;-)
> >>
> >> Hi,
> >>   first of all, a big fat note. The tests with 3.8.2 and 3.8.2 I always did with aciphp
> >> and pcie_aspm=off. I somehow forgot about that and yesterday after testing the
> >> patch from Huang Ying when it turned out the patch actually not only helps with the
> >> dead xHCI port due to suspend but incidentally also fixes the eSATA card hotplug ...
> > 
> > Which patch you're talking about?
> 
> I mean this patch 
> 
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Subject: PCI / PM: Disable runtime PM of PCIe ports
> 
> The runtime PM of PCIe ports turns out to be quite fragile, as in
> some cases things work while in some other cases they don't and we
> don't seem to have a good way to determine whether or not they are
> going to work in advance.
> 
> For this reason, avoid enabling runtime PM for PCIe ports by
> keeping their runtime PM reference counters always above 0 for the
> time being.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
>  drivers/pci/pcie/portdrv_pci.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> 
> 
> https://patchwork.kernel.org/patch/2359611/
> 
> which, also appearing like yours patch it is originally from Ying, right?:

No, I think that Ying was referring to a different patch he had attached.

Thanks,
Rafael


> <quote>
> Hi, Martin,
> 
> Sorry for late.  Just found your bug report.  That seems related with
> PCIe port runtime PM support.
> 
> Can you try the debug patch attached?  And send me back the dmesg?
> 
> Sorry I use gmail web client, so I can only send patch as attachment.
> 
> Best Regards,
> Huang Ying
> </quote>


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux