On Mon, Mar 4, 2013 at 10:58 AM, Emmanuel Grumbach <egrumbach@xxxxxxxxx> wrote: > On Mon, Mar 4, 2013 at 5:48 PM, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: >> On Mon, Mar 04, 2013 at 04:57:46PM +0200, Emmanuel Grumbach wrote: >> >>> This is what I did. On 3.7, lspci tells me that ASPM is enabled before >>> I load the module. And same after I load the module. >> >> CONFIG_PCIEASPM disabled ? >> > > nope - enabled on both kernel: 3.1 and 3.7. Makes sense though. > CONFIG_PCIEASPM enabled, I have L1. Just wondering why doesn't that > pci_disable_link_state do anything.... > Also, I remember so issues Mathew Garret debugged and he ended up > disabling ASPM on older kernel because some BIOS issue (don't remember > really). Apparently, ASPM is enabled again in newer kernels. > > Anyway - I think I will just remove this pci_disable_link_state call > and hopefully, it will stay long enough in linux-next so that people > will report issues before it get into linux. > I don't like leaving that code if it doesn't do anything. I think we broke at least some cases of pci_disable_link_state() a while back. I'd like to fix it rather than just removing calls to it. Can someone collect a complete dmesg log and "lspci -vv" output? Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
