On Thu, Mar 28, 2013 at 1:41 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > On Wed, Mar 27, 2013 at 3:56 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >> >> Why can't we set all the ASPM flags *first*, before calling >> pci_acpi_scan_root()? That way we could just do the correct ASPM >> setup as we discover devices during enumeration, rather than trying to >> fix things up afterwards. I suspect pcie_clear_aspm() is broken >> anyway, because it looks like it only touches one level of the >> hierarchy, without recursively descending it. > > Yes, we can clean up aspm stop/clear up. > and that should be for 3.10 right? > > But this patch should be safe for 3.9 and stable. This patch might be *safe*, but it (and the changelog) are completely unintelligible. The problem with applying an unintelligible stop-gap patch is that it becomes forever part of the changelog, and it's a huge waste of time to everybody who tries to understand the history later. That's why I think it's worth spending some time to make a good patch now. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
