Dear Arnd Bergmann,
On Tue, 26 Mar 2013 17:07:41 +0000, Arnd Bergmann wrote:
> I think the @d0020000 part needs to be removed for the nodes that
> have no reg property.
Sure, will fix.
> I think I did not follow the entire discussion. What has led to having
> two subnodes in the end, rather than a single node like this?
>
>
> interrupt-controller@d0020000 {
> compatible = "marvell,mpic";
> #interrupt-cells = <1>;
> #msi-cells = <1>;
> #address-cells = <1>;
> #size-cells = <1>;
> interrupt-controller;
> msi-controller;
> reg = <0xd0020a00 0x1d0>,
> <0xd0021070 0x58>;
> marvell,doorbell = <0xd0020a04>;
> };
I've tried to explain that in the commit log of PATCH 6, which says:
However, we need the driver to expose two different IRQ domains: one
for the main interrupt controller itself, and one for the MSI
interrupt controller. In order to achieve this, we will create two
subnodes in the interrupt-controller@d0020000 node: one subnode for
the main interrupt controller, and one subnode for the MSI interrupt
controller. The two irq domains can't be registered on the same DT
node, otherwise when irq_find_host() gets used by of_irq_map_one()
to resolve IRQs of devices, they may find the MSI interrupt
controller instead of the main interrupt controller.
Note that both the parent and the child node need to have the
'interrupt-controller' empty property:
* The interrupt-controller property is needed in the main
interrupt controller node (interrupt-controller@d0020000) because
the of_irq_init() function skips nodes that are matching the given
compatible string, but that don't have the interrupt-controller
property.
* The interrupt-controller property is needed in the child
interrupt controller node (main-intc@d0020000) otherwise the
resolution done by of_irq_map_one() doesn't work.
So really, the thing is that irq_domain_add_linear() registers an IRQ
domain on a specific DT node, and then irq_find_host() finds back an
IRQ domain from a given DT node. So if you have two IRQ domains
registered on the same DT node, then you don't know which one will be
used.
So if I do the two irq_domain_add_linear() (one for MPIC, one for MSI)
on one single DT node, when the timer driver will request its
interrupt, it turns out that the MSI IRQ domain is used and not the
MPIC IRQ domain, even though the timer has <&mpic> as its interrupt
parent.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
