On 03/13/2013 05:48 PM, Mitch Bradley wrote: > On 3/13/2013 11:33 AM, Thierry Reding wrote: >> On Wed, Mar 13, 2013 at 10:58:02AM -1000, Mitch Bradley wrote: >> [...] >>> In this case, the answer to "what does pcie_controller do?" is "it >>> implements a PCI bus" below. So 'device_type = "pci"' is appropriate. >> >> Alright, that's 2 against 1. I don't have much of a choice but to yield. > > All issues of "voting" aside, 'device_type = pci' is what tells > of_get_pci_address() to use the 3/2 interpretation. So if you want a > node to implement 3/2 addresses, it must say device_type = pci, unless > you do address translation some other way. I should note that device_type is used for OF, but is supposed to not be used for FDT as matching against compatible properties is preferred. I don't have a good reason as to why, but Mitch may know the history. However, there are numerous exceptions to that for compatibility and to work with existing s/w. So this may be one of those cases. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
