Dear Thierry Reding, On Fri, 8 Mar 2013 21:13:40 +0100, Thierry Reding wrote: > On Fri, Mar 08, 2013 at 01:02:46PM -0700, Jason Gunthorpe wrote: > > On Fri, Mar 08, 2013 at 09:43:11AM -1000, Mitch Bradley wrote: > [...] > > > 2) The "@0,0" and "@1,0" suffixes do not correspond to the reg values > > > <0x0800 0 0 0 0> and <0x1000 0 0 0 0> using any rule that I know. > > > > @0,1,0 (bus,device,fn) could be more appropriate, but that is > > cosmetic? > > The OF PCI specification is pretty strict about this as well. It says in > section 2.2.1.3. that only the DD and DD,FF forms can appear in a device > path. Note that in the case of my driver, the @X,Y represent the port and lane of the PCIe interface. Not sure if it is correct, I can change the names to whatever is appropriate, those names aren't used anywhere in the driver. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
