Hi, Bjorn I will update mvsas and ahci with the macro, just need more time to test it. Thanks! > -----Original Message----- > From: Bjorn Helgaas [mailto:bhelgaas@xxxxxxxxxx] > Sent: 2013年3月8日 0:25 > To: yxlraid@xxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Xiangliang Yu > Subject: Re: [PATCH 1/2] PCI: define macro for marvell vendor ID > > On Thu, Mar 7, 2013 at 7:28 AM, <yxlraid@xxxxxxxxx> wrote: > > From: Xiangliang Yu <yuxiangl@xxxxxxxxxxx> > > > > Define PCI_VENDOR_MARVELL_ID_EXT macro for 0x1b4b vendor ID > > "PCI_VENDOR_MARVELL_ID_EXT" is not actually the symbol you defined below. > > Per the comment at the top of pci_ids.h, we don't add things here > unless they are shared between multiple drivers. > > That said, the 0x1b4b vendor ID is used in mv_init.c, mvumi.h, > mvumi.c, and ahci.c. If you want to unify all those so they all use > same symbol, and define that symbol here in pci_ids.h, that would be > fine with me. > > > --- > > include/linux/pci_ids.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > index f11c1c2..a80f9e6 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -1604,6 +1604,7 @@ > > #define PCI_SUBDEVICE_ID_KEYSPAN_SX2 0x5334 > > > > #define PCI_VENDOR_ID_MARVELL 0x11ab > > +#define PCI_VENDOR_ID_MARVELL_EXT 0x1b4b > > #define PCI_DEVICE_ID_MARVELL_GT64111 0x4146 > > #define PCI_DEVICE_ID_MARVELL_GT64260 0x6430 > > #define PCI_DEVICE_ID_MARVELL_MV64360 0x6460 > > -- > > 1.7.5.4 > > ?韬{.n?????%??檩??w?{.n???{炳???骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
