On Fri, Feb 1, 2013 at 12:50 AM, Yijing Wang <wangyijing@xxxxxxxxxx> wrote: > On 2013/1/31 23:59, Yinghai Lu wrote: >> On Thu, Jan 31, 2013 at 7:37 AM, Jiang Liu <liuj97@xxxxxxxxx> wrote: >>> >>> So I think the code in handle_hotplug_event_bridge() to handle P2P hot-addition >>> is dead. Yijing has helped to test the code by faking ACPI CUSTOM_METHOD, and it >>> does work as expected. >> >> ok, then. >> >> It would be better if you can append some print out from Yijing's test >> in the changelog. >> > > Hi Yinghai, > I used custom_method module to make root port device 0000:00:07.0 support acpi hotplug (by adding _EJ0 method), > This root port device also connected to a slot which support hotplug. I tested to hot plug root port device 0000:00:07.0, > and test steps and info as bellow, if there are somethings missing during test, please let me know. > Thanks very much! > > linux-ha2:/sys/bus/pci/slots # lspci -tv > \-[0000:00]-+-00.0 Intel Corporation 5520/5500/X58 I/O Hub to ESI Port > +-01.0-[0000:01]--+-00.0 Intel Corporation 82576 Gigabit Network Connection > | \-00.1 Intel Corporation 82576 Gigabit Network Connection > +-03.0-[0000:02]----00.0 LSI Logic / Symbios Logic SAS1064ET PCI-Express Fusion-MPT SAS > +-04.0-[0000:03]-- > +-05.0-[0000:04]-- > +-07.0-[0000:05]--+-00.0 nVidia Corporation GT218 [GeForce G210] > | \-00.1 nVidia Corporation High Definition Audio Controller > +-0d.0 Intel Corporation Device 343a > linux-ha2:/sys/bus/pci/slots # ls > 0 0-1 1 3 5 7 > linux-ha2:/sys/bus/pci/slots # cat 1/address > 0000:00:07 > linux-ha2:/sys/bus/pci/slots # cd 1 > linux-ha2:/sys/bus/pci/slots/1 # ls > adapter address attention cur_bus_speed latch max_bus_speed module power > linux-ha2:/sys/bus/pci/slots/1 # cat power > 1 > linux-ha2:/sys/bus/pci/slots/1 # echo "\_SB_.NOD0.PCI0.MRP7 3" > /sys/kernel/debug/acpi/sci_notify > linux-ha2:/sys/bus/pci/slots/1 # cat power > 0 > linux-ha2:/sys/bus/pci/slots/1 # lspci -tv > \-[0000:00]-+-00.0 Intel Corporation 5520/5500/X58 I/O Hub to ESI Port > +-01.0-[0000:01]--+-00.0 Intel Corporation 82576 Gigabit Network Connection > | \-00.1 Intel Corporation 82576 Gigabit Network Connection > +-03.0-[0000:02]----00.0 LSI Logic / Symbios Logic SAS1064ET PCI-Express Fusion-MPT SAS > +-04.0-[0000:03]-- > +-05.0-[0000:04]-- > +-0d.0 Intel Corporation Device 343a > linux-ha2:/sys/bus/pci/slots/1 # echo "\_SB_.NOD0.PCI0.MRP7 1" > /sys/kernel/debug/acpi/sci_notify > linux-ha2:/sys/bus/pci/slots/1 # cat power > 1 > linux-ha2:/sys/bus/pci/slots/1 # lspci -tv > \-[0000:00]-+-00.0 Intel Corporation 5520/5500/X58 I/O Hub to ESI Port > +-01.0-[0000:01]--+-00.0 Intel Corporation 82576 Gigabit Network Connection > | \-00.1 Intel Corporation 82576 Gigabit Network Connection > +-03.0-[0000:02]----00.0 LSI Logic / Symbios Logic SAS1064ET PCI-Express Fusion-MPT SAS > +-04.0-[0000:03]-- > +-05.0-[0000:04]-- > +-07.0-[0000:05]--+-00.0 nVidia Corporation GT218 [GeForce G210] > | \-00.1 nVidia Corporation High Definition Audio Controller > +-0d.0 Intel Corporation Device 343a looks good. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html