On Tue, Jan 29, 2013 at 04:23:37PM +0100, Thomas Petazzoni wrote: > Russell, > > Thanks for your quick feedback! > > On Tue, 29 Jan 2013 15:15:01 +0000, Russell King - ARM Linux wrote: > > > Given the description, I'd feel much happier with this if we specified > > the alignment numerically rather than allowing "some random code" to do > > something with the passed values. > > So, you'd prefer to have two new members added in the hw_pci structure > to give the alignment requirements for I/O regions and memory regions? Yep, otherwise we'll have yet more code to review rather than one algorithm with a set of numbers... I work on the principle that if something can be expressed numerically, that's always better than expressing it with code. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
