On Tue, 2013-01-29 at 12:35 +0100, Rafael J. Wysocki wrote: > On Tuesday, January 29, 2013 11:35:32 AM Paul Bolle wrote: > > Thanks. So should the fix here be to actually suspend and remove this > > device? (Note that pciehp_suspend() is now basically a NOP.) > > I think it wouldn't be useful to remove devices on all suspends, but then there > are a few different situations that resume has to consider and handle correctly: > > 1) Device has been removed while suspended. > 2) Device was present before suspend and is still there. > 3) Device has been added while suspended. Obviously, I care about situation 2) here. (It would be quite a feat to remove or add a wireless card while the laptop is suspended.) Anyhow, is there any reason to not treat the fact that a device turns out to be already there when board_added() is called as an occurrence of situation 2)? In other words: is the only reason that a device already exists when board_added() is called that it was there while suspending and is still there while resuming? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
