On Sun, Jan 20, 2013 at 3:23 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Thursday, January 17, 2013 11:53:22 PM Yinghai Lu wrote:
>> We want to put created pci device in the device tree as soon as possible.
>> - just after we find it and create pci_dev struct for it.
>> so for_pci_dev iteration will not miss them.
>>
>> But at that time, we can not load driver for them yet. Need to be after
>> pci_assign_unsigned_resources() etc to make sure all pci devices get
>> resource allocated at first.
>>
>> Move out device registering out of pci_bus_add_devices, and
>> new pci_bus_add_devices() will do the device_attach work to load pci drivers
>>
>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>> ---
>> drivers/pci/bus.c | 47 +++--------------------------------------------
>> drivers/pci/iov.c | 7 -------
>> drivers/pci/probe.c | 34 +++++++++++++++++++++++++++-------
>> 3 files changed, 30 insertions(+), 58 deletions(-)
>>
>> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
>> index 18c1c6d..0a55845 100644
>> --- a/drivers/pci/bus.c
>> +++ b/drivers/pci/bus.c
>> @@ -178,22 +178,9 @@ static void pci_bus_attach_device(struct pci_dev *dev)
>> */
..
>> @@ -205,21 +192,9 @@ int pci_bus_add_device(struct pci_dev *dev)
>> */
>> int pci_bus_add_child(struct pci_bus *bus)
>> {
>> - int retval;
>> -
>> - if (bus->bridge)
>> - bus->dev.parent = bus->bridge;
>> -
>> - retval = device_register(&bus->dev);
>> - if (retval)
>> - return retval;
>> -
>> bus->is_added = 1;
>>
>> - /* Create legacy_io and legacy_mem files for this bus */
>> - pci_create_legacy_files(bus);
>> -
>> - return retval;
>> + return 0;
>> }
>
> Well, what sense does this make to keep that function as is after removing
> almost all of the code from it?
ok, will remove that function.
...
>> list_for_each_entry(dev, &bus->devices, bus_list) {
>> BUG_ON(!dev->is_added);
>>
>> child = dev->subordinate;
>> - /*
>> - * If there is an unattached subordinate bus, attach
>> - * it and then scan for unattached PCI devices.
>> - */
>> +
>> if (!child)
>> continue;
>> - if (list_empty(&child->node)) {
>> - down_write(&pci_bus_sem);
>> - list_add_tail(&child->node, &dev->bus->children);
>> - up_write(&pci_bus_sem);
>> - }
>
> This doesn't seem to have a replacement. Why isn't it necessary any more?
>
add that in changelog, so related changlog will be:
---
Also remove unattached child bus handling in pci_bus_add_devices().
Because that is not needed, child bus via pci_add_new_bus() is already
in parent bus children list.
---
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
