Re: [PATCH] ACPI: Remove unused struct acpi_pci_root.id member

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 19, 2012 at 6:22 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Wednesday, December 19, 2012 10:30:44 AM Bjorn Helgaas wrote:
>> This member is never initialized and never referenced, so remove it.
>
> Sure. :-)
>
> Do you want me to take this?

I assume you're going to push your namespace scan rework through your
tree, since most of the changes are in drivers/acpi.  That series also
touches acpi_bus.h, so probably makes the most sense for you to take
this as well.  I don't plan any future changes to the file.

There are more PCI-centric pci_root.c changes in the pipe, but we'll
have to sort those out later, I think.

Let me know if you think otherwise.

>> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>> ---
>>  include/acpi/acpi_bus.h |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
>> index 7ced5dc..4f42c0e 100644
>> --- a/include/acpi/acpi_bus.h
>> +++ b/include/acpi/acpi_bus.h
>> @@ -397,7 +397,6 @@ int unregister_acpi_bus_type(struct acpi_bus_type *);
>>  struct acpi_pci_root {
>>       struct list_head node;
>>       struct acpi_device * device;
>> -     struct acpi_pci_id id;
>>       struct pci_bus *bus;
>>       u16 segment;
>>       struct resource secondary;      /* downstream bus range */
>>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux