On Tue, Dec 18, 2012 at 12:48 PM, Toshi Kani <toshi.kani@xxxxxx> wrote: > On Tue, 2012-12-18 at 10:59 -0800, Yinghai Lu wrote: >> On Tue, Dec 18, 2012 at 8:10 AM, Toshi Kani <toshi.kani@xxxxxx> wrote: >> > On Tue, 2012-12-18 at 02:48 +0100, Rafael J. Wysocki wrote: >> > >> > So, I would propose the following changes. >> > >> > - Move the acpi_hot_add_bind() call back to the original place after >> > the device_attach() call. >> > - Rename the name of acpi_hot_add_bind() to something like >> > acpi_bind_adr_device() since it is no longer hot-add only (and is >> > specific to _ADR devices). >> > - Create its pair function, acpi_unbind_adr_device(), which is called >> > from acpi_bus_remove(). When a constructor interface is introduced, its >> > destructor should be introduced as well. >> > - Remove the binding procedure from acpi_pci_root_add(). This should >> > be done in patch [2/6]. >> >> i think we should put jiang four patches before Rafael's patches. >> >> http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=shortlog;h=refs/heads/for-pci-jiang-hotplug > > Thanks for the pointer! Oh, I did not know that pci_dev gets removed > before acpi_bus_trim() is called... yes. that is http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=commitdiff;h=8b4b836d8c56c290bc80ffa0b08b91fb3fe38867 > I looked at Jiang's last two > patches for the bind update, and they look good to me. > > Thanks, > -Toshi > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
