On Mon, Nov 05, 2012 at 05:11:08PM -0700, Jon Mason wrote: > +static int __init ntb_init_module(void) > +{ > + pr_info("%s: %s, version %s\n", KBUILD_MODNAME, NTB_NAME, NTB_VER); No need to be noisy. > + > + return pci_register_driver(&ntb_pci_driver); > +} > +module_init(ntb_init_module); > + > +static void __exit ntb_exit_module(void) > +{ > + pci_unregister_driver(&ntb_pci_driver); > + > + pr_info("%s: Driver removed\n", KBUILD_MODNAME); Same here, don't print out needless things. > +} > +module_exit(ntb_exit_module); This all can be wrapped up using the pci_module() macro instead. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html