Re: [PATCH] PCI/portdrv: Fix regression introduced by commit 2dcfaf85

[Yinghai Lu <yinghai@xxxxxxxxxx>]

On Tue, Oct 30, 2012 at 5:51 PM, Taku Izumi <izumi.taku@xxxxxxxxxxxxxx> wrote:
>
> PCI/portdrv: Fix regression introduced by commit 2dcfaf85
>
> After commit 2dcfaf85, hotplug slots for port devices
> w/o slot implementation come to be created.
> This patch fixes this problem.
>
> Signed-off-by: Taku Izumi <izumi.taku@xxxxxxxxxxxxxx>
> ---
>  drivers/pci/pcie/portdrv_core.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: pci/drivers/pci/pcie/portdrv_core.c
> ===================================================================
> --- pci.orig/drivers/pci/pcie/portdrv_core.c
> +++ pci/drivers/pci/pcie/portdrv_core.c
> @@ -272,7 +272,8 @@ static int get_port_device_capability(st
>         }
>
>         /* Hot-Plug Capable */
> -       if (cap_mask & PCIE_PORT_SERVICE_HP) {
> +       if ((cap_mask & PCIE_PORT_SERVICE_HP) &&
> +           dev->pcie_flags_reg & PCI_EXP_FLAGS_SLOT) {
>                 pcie_capability_read_dword(dev, PCI_EXP_SLTCAP, &reg32);
>                 if (reg32 & PCI_EXP_SLTCAP_HPC) {
>                         services |= PCIE_PORT_SERVICE_HP;
>

Acked-by: Yinghai Lu <yinghai@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html