On Tue, Oct 02, 2012 at 04:23:40PM -0400, Don Dutile wrote: > Greg: Why not use the above functions? What "above functions"? You make a lot of calls in the code :) You are creating an attribute group, and then manually walking through it to create/destroy the file? That's not good, use the in-kernel functions to do that automatically for you. Also, you need to do this _before_ the device shows up to userspace, otherwise you have a race that you just lost with udev and the like. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html