On Tue, Sep 25, 2012 at 9:57 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Tue, Sep 25, 2012 at 1:35 AM, Lan Tianyu <lantianyu1986@xxxxxxxxx> wrote:
>> 2012/9/25 Yinghai Lu <yinghai@xxxxxxxxxx>:
>>> The struct member is not used anymore, remove it.
>>>
>>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>>> Cc: linux-usb@xxxxxxxxxxxxxxx
>>> ---
>>> drivers/usb/core/usb-acpi.c | 1 -
>>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/usb/core/usb-acpi.c b/drivers/usb/core/usb-acpi.c
>>> index 8947b20..a6ea613 100644
>>> --- a/drivers/usb/core/usb-acpi.c
>>> +++ b/drivers/usb/core/usb-acpi.c
>>> @@ -102,7 +102,6 @@ static int usb_acpi_find_device(struct device *dev, acpi_handle *handle)
>>>
>>> static struct acpi_bus_type usb_acpi_bus = {
>>> .bus = &usb_bus_type,
>>> - .find_bridge = NULL,
>>> .find_device = usb_acpi_find_device,
>>> };
>>>
>> HI Yinghai:
>> This member has been populated in the usb-next tree.
>>
>> http://git.kernel.org/?p=linux/kernel/git/gregkh/usb.git;a=commit;h=d557542421da643358201664903e67fd01dfca1a
>
> Thanks for pointing that out.
>
> Looks that following change is not needed in that commit.
>
> @@ -102,7 +139,7 @@ static int usb_acpi_find_device(struct device
> *dev, acpi_handle *handle)
>
> static struct acpi_bus_type usb_acpi_bus = {
> .bus = &usb_bus_type,
> - .find_bridge = NULL,
> + .find_bridge = usb_acpi_find_device,
> .find_device = usb_acpi_find_device,
> };
>
after looking your code closely, that find_bridge is still needed.
that usb_port does not have usb_bus_type.
but mixing find bridge and find device cause confusing.
Please check attached patch that will separate find_bridge out.
-Yinghai
Attachment:
usb_acpi_find_bridge.patch
Description: Binary data
