On Mon, Sep 17, 2012 at 05:03:56PM -0700, Yinghai Lu wrote: > On Mon, Sep 3, 2012 at 8:27 PM, Ram Pai <linuxram@xxxxxxxxxx> wrote: > > On Mon, Sep 03, 2012 at 11:20:45AM -0700, Yinghai Lu wrote: > >> On Mon, Sep 3, 2012 at 2:08 AM, Ram Pai <linuxram@xxxxxxxxxx> wrote: > >> > On Mon, Sep 03, 2012 at 01:07:46AM -0700, Yinghai Lu wrote: > >> > > >> > Anyway I am ok with either patch. > >> > >> please check -v7. > > > > Looks good to me. I am inlining the patch for others to comment. > > BTW: your patch that introduces pci_dev_resource_n() will have > > to be applied before applying this patch. > > > > > > just updated for-pci-for-each-res-addon branch... > > http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=shortlog;h=refs/heads/for-pci-for-each-res-addon > > now it only depends on pci-root-bus-hotplug now, and > pci-root-bus-hotplug only depends on pci/next without busn-alloc. > > So after Bjorn accept pci-root-bus-hotplug, we could push that to him. > > Please check for-pci-for-each-addon branch. > git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git > for-pci-for-each-res-addon Checked and the patch looks good. But later you have added another patch which introduces lot many macros ... Will that patch also be pushed to Bjorn? I thought Bjorn resisted the idea of having multiple such iterators.. This is the patch I am talking about: commit a37fbc4685ab086581f9842630c997ca78186ea4 Author: Yinghai Lu <yinghai@xxxxxxxxxx> Date: Mon Sep 3 00:32:00 2012 -0700 PCI: Add for_each_resource helpers to make resource loop easier. +#define resno_is_for_bridge(n) \ + ((n) >= PCI_BRIDGE_RESOURCES && (n) <= PCI_BRIDGE_RESOURCE_END) + +/* all (include bridge) resources */ +#define for_each_pci_dev_all_resource(dev, res, i) \ + for_each_pci_resource(dev, res, i, PCI_ALL_RES) ....... ...... -- Ram Pai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
