On Mon, Aug 20, 2012 at 7:46 AM, Gavin Shan <shangw@xxxxxxxxxxxxxxxxxx> wrote:
> The patch changes the variable name for function find_pci_host_bridge()
> so that it looks more meaningful. More specificly, the "bus" has been
> replaced with "root_bus".
>
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> Signed-off-by: Gavin Shan <shangw@xxxxxxxxxxxxxxxxxx>
I don't understand the point of patches 1-3:
pci: change variable name for find_pci_host_bridge
pci: argument pci_bus for find_pci_host_bridge
pci: fiddle with conversion of pci and CPU address
As far as I can tell, they don't have anything to do with patches 4-8.
I don't mind considering them later if they make things easier to read
or if they enable some other rework, but right now I want to make
progress on the P2P window alignment stuff, and patches 1-3 seem to be
distractions from that.
> drivers/pci/host-bridge.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c
> index a68dc61..c19776a 100644
> --- a/drivers/pci/host-bridge.c
> +++ b/drivers/pci/host-bridge.c
> @@ -22,9 +22,9 @@ static struct pci_bus *find_pci_root_bus(struct pci_dev *dev)
>
> static struct pci_host_bridge *find_pci_host_bridge(struct pci_dev *dev)
> {
> - struct pci_bus *bus = find_pci_root_bus(dev);
> + struct pci_bus *root_bus = find_pci_root_bus(dev);
>
> - return to_pci_host_bridge(bus->bridge);
> + return to_pci_host_bridge(root_bus->bridge);
> }
>
> void pci_set_host_bridge_release(struct pci_host_bridge *bridge,
> --
> 1.7.5.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
