Hi Bjorn, The drivers/pci/remove.c now is so clean after applied series "[PATCH v2 00/16] Clean up drivers/pci/remove.c"(very good ^_^). I have a small problem about pci_stop_and_remove_bus_device() function. Traditionally, pci_bus is removed after its pci bridge stop. But now pci_bus is remove before its pci brdige. So If I use pci_bus_type notifier, I can't identify pci_dev whether is bridge(by pci_dev->subordinate) when notifier arrives. What about move pci_remove_bus after stop pci bridge? 82 if (bus) { 83 list_for_each_entry_safe_reverse(child, tmp, 84 &bus->devices, bus_list) 85 pci_stop_and_remove_bus_device(child); 86 87 } 88 89 pci_stop_dev(dev); 90 if (bus) { 91 pci_remove_bus(bus); 92 dev->subordinate = NULL; 93 } 94 pci_destroy_dev(dev); -- Thanks! Yijing -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html