On 2012/8/17 10:34, Bjorn Helgaas wrote: > On Thu, Aug 16, 2012 at 6:58 PM, Yijing Wang <wangyijing@xxxxxxxxxx> wrote: >> Hi Bjorn, >> Please ignore these three patches, I'm very sorry I still have some confusion about allocating resources >> to pci devices.So this patch is not appropriate. I will provide new version patches when I find a better >> solution for this problem. > > We don't have a uniform way of detecting unassigned BARs and handling > resource allocation failures yet. When we make that all consistent, I > think it will make it more obvious how to do these patches. Yes, I also think maybe we need one uniform way to detecting unassigned BARs and resources that be assigned failure.Then if necessary, some codes which want to correct or re-assign resoruces for pci dev could do that more clearly. I will try to analyse that, and propose some patches as soon. Thanks! > I think patch 2/3 (the list_for_each_safe() one) is probably still a > good bug fix, so with your permission, I'll keep that one. Sure,that's ok. >>> When we hot plug pci devices, system will allocate resources to these new add >>> devices, pci_bus_assign_resources() will be called.If the pci devices was assigned >>> resource fail, the resource struct will reset to zero.So I think use res->flags here >>> to determine whether the resource is valid is reliable. -- Thanks! Yijing -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
