On Wed, Aug 15, 2012 at 09:11:03PM -0700, Yinghai Lu wrote: > On Wed, Aug 15, 2012 at 8:26 PM, Ram Pai <linuxram@xxxxxxxxxx> wrote: > > On Wed, Aug 15, 2012 at 03:25:06PM -0600, Bjorn Helgaas wrote: > > > > I am fine with this approach. I have never encountered the need for 'no' > > based iterator like 'for_each_pci_dev_noiov_resource' or > > 'for_each_pci_dev_base_norom_resource'. While abstracting the code and > > replacing explicit references to the resources in various peices of code > > including the drivers, I just encountered the need for the 'yes' based > > iterators like the one that I added. > > > > However if there is a need for 'no' based iterators, it should be easy > > to incorporate them using flags. Something like > > > > for_each_pci_resource(dev, res, i, flags) > > > > where flags can be > > #define PCI_STD_RES 0x01 > > #define PCI_ROM_RES 0x02 > > #define PCI_BRIDGE_RES 0x04 > > #define PCI_IOV_RES 0x08 > > #define PCI_ALL_RES PCI_STD_RES|PCI_ROM_RES|PCI_BRIDGE_RES|PCI_IOV_RES > > #define PCI_NOSTD_RES PCI_ALL_RES&(^PCI_STD_RES) > > #define PCI_NOIOV_RES PCI_ALL_RES&(^PCI_IOV_RES) > > so on and so forth > > > > Yinghai if you are ok with this approach, let me code up all the > > iterators. You can incorporate your patches based on those iterators and > > I can change all my 40+ patches that change various driver sources to > > use this iterator. > > Do you mean that you will have updated patch for > http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=commitdiff;h=cd192f0ed93203ef6bac2a44c138899190fb5793 > ? Yes. > > if it is that case, i am ok, and then I could use scripts to update > following patches. Ok. Will have it your way soon. RP -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
