> On Wed, Aug 15, 2012 at 7:13 AM, Yijing Wang <wangyijing0307@xxxxxxxxx> wrote: >> Hi all, >> I have some confusion on acpiphp_sanitize_bus() functions.If I understand wrong about this, correct me,thanks your help. >> I think there are three problems in this function: >> 1、Use list_for_each_entry here is not safe, because pci_stop_and_remove_bus_device() will remove the device from bus. >> 2、If assign resources fail after hot-add a device, the resource will reset to zero, in reset_resource(), res->start = 0, >> res->end =0, res->end = 0. >> 3、I think leave the fail pci devices in the system is better rather than remove them, so we can see all pci devices >> by lspci after hot-add, what about your opinion? > > These sound like reasonable concerns. The best thing to do is to > propose patches (separate ones for each logical issue). Then we can > review a concrete change and apply it if appropriate. > Hi Bjorn, Thanks for your comments! You are right, I will provide some patches as soon. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html