On Fri, Mar 14, 2025 at 06:31:48PM +0100, Danilo Krummrich wrote: > On Fri, Mar 14, 2025 at 10:21:58AM -0700, Boqun Feng wrote: > > On Fri, Mar 14, 2025 at 05:09:05PM +0100, Danilo Krummrich wrote: > > > Some bus device functions should only be called from bus callbacks, > > > such as probe(), remove(), resume(), suspend(), etc. > > > > > > To ensure this add device context marker structs, that can be used as > > > generics for bus device implementations. > > > > > > Reviewed-by: Benno Lossin <benno.lossin@xxxxxxxxx> > > > Suggested-by: Benno Lossin <benno.lossin@xxxxxxxxx> > > > > Try chronological order for the tags? It was suggested first and then > > reviewed. > > Is that a thing? When I apply patches I usully keep ACKs, RBs and SOBs together > at the bottom. I don't think it's a hard requirement, but it makes logical sense to order the tags except your own SoB based on chronological order when re-submitting a new version IMO. It's in the same spirit of putting SoBs in chronological when multiple people handle the patches. But it's your choice, I just feel it's a bit odd in the current order ;-) Regards, Boqun