Re: [PATCH] PCI: xilinx-cpm: Fix incorrect version check in init_port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

> Fix an incorrect conditional check in xilinx_cpm_pcie_init_port().
> 
> The previous condition mistakenly skipped initialization for all
> versions except CPM5NC_HOST. This is now corrected to ensure that only
> the CPM5NC_HOST is skipped while other versions proceed with
> initialization.

[...]
>  {
>  	const struct xilinx_cpm_variant *variant = port->variant;
>  
> -	if (variant->version != CPM5NC_HOST)
> +	if (variant->version == CPM5NC_HOST)
>  		return;
>  
>  	if (cpm_pcie_link_up(port))

Ouch!  Nice catch.

I will pull and squash this against the existing code directly on the branch.

Thank you!

	Krzysztof




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux