On Tue, 7 Aug 2012, Ming Lei wrote: > On Tue, Aug 7, 2012 at 7:23 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > >> Yes, I agree, but I don't think it may make .runtime_post_resume > >> not doable, do I? > > > > No more device PM callbacks, please. > > IMO, what the patch is doing is to introduce one callback which > is just called after .runtime_resume is completed, and you want > to move something out of previous .runtime_resume and do it > in another new callback to speedup resume, so it should be > reasonable to introduce the .runtime_post_resume callback in logic. No, that's really not what the patch is doing. The idea behind the new API is that "func" will be called as soon as we know the device is at full power. That could be after the next runtime resume or it could be right away. This is a one-time call; it should not be made _every_ time the device resumes. > Also, the 'func' should be per driver, not per device since only one > 'func' is enough for all same kind of devices driven by one same > driver. But what if the subsystem defines its own dev_pm_info structure? Then the driver's dev_pm_info will be ignored by the runtime PM core. All the subsystems would have to be changed. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
