On Fri, Mar 07, 2025 at 11:46:34AM +0300, Dan Carpenter wrote:
> This put_device() was accidentally left over from when we changed the
> code from using device_register() to calling device_add(). Delete it.
>
> Fixes: 9885440b16b8 ("PCI: Fix pci_host_bridge struct device release/free handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Applied to pci/enumeration for v6.15, thanks!
> ---
> drivers/pci/probe.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 9ce83a1d6e31..819d23ce3565 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -999,10 +999,9 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge)
> /* Temporarily move resources off the list */
> list_splice_init(&bridge->windows, &resources);
> err = device_add(&bridge->dev);
> - if (err) {
> - put_device(&bridge->dev);
> + if (err)
> goto free;
> - }
> +
> bus->bridge = get_device(&bridge->dev);
> device_enable_async_suspend(bus->bridge);
> pci_set_bus_of_node(bus);
> --
> 2.47.2
>
